Fix the nested ripple effects in small screens sidebar component #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `Button` component in small screens sidebar to `a` tag to avoid the an unnecessary nested ripple effect that `Button` component causes because it is inside `MenuItem` component which has a ripple effect. Give the `a` tag `classes.unstyledLink` class to overwrite its default styles. Remove `.sidebarLink` class from `navbar` styles file because the only component that uses this class has been changed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AbdulrhmanGoni
changed the title
Button component in small screens sidebar to a tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #288
What change does this pull request introduce?
Changes
Buttoncomponent in small screens sidebar toatag to avoid the an unnecessary nested ripple effectsthat
Buttoncomponent causes because it is insideMenuItemcomponent which has the same ripple effect.Gives the
atagclasses.unstyledLinkclass to overwrite its default styles.Removes
.sidebarLinkclass fromnavbarstyles file because the only component that uses this class has been changed.Screenshots
Before changes:
After changes:
Checklist
main.mainbranch.yarn lint.yarn buildto check everything still builds successfully.